Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ares_create_query: avoid single-byte buffer overwrite
... when the name ends with an escaped dot. CVE-2016-5180 Bug: https://c-ares.haxx.se/adv_20160929.html
- Loading branch information
Showing
1 changed file
with
39 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65c71be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting following warnings after this patch, are these ignorable?
65c71be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit didn't introduce the use of
ares_malloc
so surely it happened already before then?This source file includes
ares_private.h
where theares_malloc
function pointer is extern-declared. I get no warnings with current git.65c71be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize I had an earlier version of this file which was missing few commits.