Windows: Reload config on manual DNS changes #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NotifyIpInterfaceChange()method only notifies of automatic changes, such as via DHCP or interfaces going up or down. However, someone editing the DNS settings manually would not trigger a notification.Use
RegNotifyChangeKeyValue()to monitorHKLM\SYSTEM\CurrentControlSet\Services\Tcpip6\Parameters\InterfacesandHKLM\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\Interfacesto pick up these changes.This new check also works when using the OpenWatcom compiler as the symbols are available, so they have been enabled (though
NotifyIpInterfaceChange()method is disabled for OpenWatcom still due to the linker libraries missing this symbol).NOTE: it does appear that about 5 events get triggered for some reason, it doesn't seem to hurt anything, but it will actually cause it to re-read the configuration multiple times.
Fixes Issue: #761
Fix By: Brad House (@bradh352)