Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding & Endpoints errors #2

Closed
c-bertran opened this issue Jul 21, 2023 · 4 comments
Closed

Encoding & Endpoints errors #2

c-bertran opened this issue Jul 21, 2023 · 4 comments
Assignees
Labels
bug Something isn't working under correction the bug is being fixed

Comments

@c-bertran
Copy link
Owner

c-bertran commented Jul 21, 2023

Thank you @c-bertran for your effort put into fixing this. I really appreciate it and thank you. Error 500 has been fixed, but unfortunately, a few new errors have appeared now.

  1. In the express-autoindex@^1.3.0 version, the character encoding for static files has stopped working correctly.

test.txt file encoding: UTF-8 without BOM

  1. Endpoints like /xxx/yyy/zzz/generated do not work with express-autoindex, even though they are correctly served statically.

Thank you also for adding the customTemplate option! There is no other npm module like yours, so I plan to use it anyway - even if it doesn't work perfectly 100%.

Originally posted by @sefinek24 in #1 (comment)

@c-bertran c-bertran added bug Something isn't working under correction the bug is being fixed labels Jul 22, 2023
@c-bertran c-bertran self-assigned this Jul 22, 2023
@c-bertran
Copy link
Owner Author

I've just added the best possible management of file encoding. It's quite complex and it's possible in some rare cases for the encoding to be unsuitable, but frankly there's very little risk.

As for the endpoints, I've been working on them for a while, and I'm confident I'll find a solution.

@c-bertran
Copy link
Owner Author

Version 1.4.0 has just been released, and I've corrected the encoding bug in the received file, as well as the multipath bug.

Normally, things should be much better

@c-bertran
Copy link
Owner Author

To close the issue, I'd need to know whether the bugs observed have been corrected or not on your project.
Thanks in advance ^^

@sefinek24
Copy link

It works! Thank you again, have a nice day or night!
See: https://blocklist.sefinek.net/json

202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working under correction the bug is being fixed
Projects
None yet
Development

No branches or pull requests

2 participants