Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"person/id/combined_credit" ? #47

Closed
icaronunes opened this issue Aug 23, 2016 · 5 comments
Closed

"person/id/combined_credit" ? #47

icaronunes opened this issue Aug 23, 2016 · 5 comments
Assignees

Comments

@icaronunes
Copy link

icaronunes commented Aug 23, 2016

Accessing this information?

I tried to look and found .

Already have or to wait ?

" Written in Portuguese , translated by google rs "

@holgerbrandl
Copy link
Collaborator

Could you provide a PR containing this new element?

@icaronunes
Copy link
Author

No, I do not have that ability yet.
I tried to look but I did not exist.

@Lundez
Copy link
Contributor

Lundez commented Jan 21, 2018

Hi! Hijacking this old issue. The "credits" doesn't work that well anymore, it only finds the movies that a Person has been a character in. Not TvSeries. Using the combined_credits would fix this, or using the two methods "tv_credits"/"movie_credits" on for each kind.

If you'd like I think I could do this and push. Just put the issue on me and I'll solve it.

See:
https://developers.themoviedb.org/3/people/get-person-combined-credits
https://developers.themoviedb.org/3/people/get-person-movie-credits
https://developers.themoviedb.org/3/people/get-person-tv-credits

@holgerbrandl
Copy link
Collaborator

Hey @Lundez, sure feel welcome to provide a PR. Reflecting the official API seems the best option, that is adding a method for combined-credits (and removing no longer working methods as needed).

@holgerbrandl
Copy link
Collaborator

solved via PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants