Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building translations now hard requires an Unix environment #150

Closed
amyspark opened this issue May 30, 2022 · 2 comments
Closed

Building translations now hard requires an Unix environment #150

amyspark opened this issue May 30, 2022 · 2 comments

Comments

@amyspark
Copy link
Contributor

Hi @c-koi,

I just noticed you moved to a Makefile-based environment for generating the .ts files: 319adab 3e51329 2411774.

The cited changes remove support for building G'MIC-Qt from Git using a Windows-based toolchain:

  • For non-MSYS2 tools, but MinGW based ones, the make tool is called mingw32-make.
  • For Visual Studio, this is now straight out impossible to build.

I'm not sure yet how these will be deployed in the next tarball, but for the time being, I've regenerated the .ts files on our side, and added some steps to build them automatically by taking advantage of qt5_add_translation and the AUTORCC property of CMake:

amyspark/gmic@52c4e82

@dtschump
Copy link
Collaborator

@amyspark , we indeed plan to provide the generated .ts and .qm files in the tarball.

@0xC0000054
Copy link
Contributor

I also ran into this issue when building the Paint.NET and 8bf versions of G'MIC-Qt 3.1.3.

I worked around the issue by changing my build script to invoke csv2ts.sh using the Git for Windows bash shell, the .qm files are then compiled by calling the MinGW lrelease binary directly.

@amyspark amyspark closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants