Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception handling command off #35

Closed
3 tasks done
c-schicho opened this issue Aug 22, 2021 · 0 comments · Fixed by #42
Closed
3 tasks done

exception handling command off #35

c-schicho opened this issue Aug 22, 2021 · 0 comments · Fixed by #42
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@c-schicho
Copy link
Owner

c-schicho commented Aug 22, 2021

the command off throws occasionally exceptions when the user calls the on and off command one after the other within a short period of time, see the screenshot below. when this is happening, the program does not crash, however, the bot is not responding and, thus the user has no information about what's happening.

  • improve the off command, change remind_user.stop() to remind_user.cancel()
  • catch exceptions thrown in off command.
  • provide an error message to the user if an exception is thrown.

#34

@c-schicho c-schicho added enhancement New feature or request good first issue Good for newcomers labels Aug 22, 2021
@c-schicho c-schicho added this to the improve exception handling milestone Aug 22, 2021
@c-schicho c-schicho self-assigned this Aug 22, 2021
@c-schicho c-schicho linked a pull request Aug 22, 2021 that will close this issue
@c-schicho c-schicho removed their assignment May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant