Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement convolutional 2D layer #17

Merged
merged 1 commit into from Jun 27, 2022
Merged

feat!: implement convolutional 2D layer #17

merged 1 commit into from Jun 27, 2022

Conversation

c0dearm
Copy link
Owner

@c0dearm c0dearm commented Jun 26, 2022

Convolutional layers with output dimensions inferred at compile time! This required a refactor of the project to be able to make it work, see: https://stackoverflow.com/questions/72742278/satisfying-a-trait-bound-with-a-const-generic-expression-is-it-possible

Unfortunately this requires nightly until the const equality and expressions are stabilized.

@c0dearm c0dearm force-pushed the conv2d branch 3 times, most recently from 3f88ed4 to 3264813 Compare June 26, 2022 11:00
@c0dearm c0dearm changed the title feat: implement convolutional 2D layer feat!: implement convolutional 2D layer Jun 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #17 (87fd5c6) into main (4287874) will decrease coverage by 2.86%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   90.73%   87.86%   -2.87%     
==========================================
  Files          13       13              
  Lines         669      676       +7     
==========================================
- Hits          607      594      -13     
- Misses         62       82      +20     
Impacted Files Coverage Δ
src/tensor/params.rs 50.00% <0.00%> (-19.24%) ⬇️
src/nn/losses.rs 81.81% <50.00%> (ø)
src/tensor/mod.rs 85.38% <57.14%> (-4.75%) ⬇️
src/nn/layers/dropout.rs 88.88% <77.77%> (-4.66%) ⬇️
src/lib.rs 97.22% <100.00%> (+5.33%) ⬆️
src/nn/activations.rs 91.30% <100.00%> (+0.12%) ⬆️
src/nn/layers/conv2d.rs 82.45% <100.00%> (-1.68%) ⬇️
src/nn/layers/linear.rs 93.75% <100.00%> (ø)
src/tensor/constant.rs 100.00% <100.00%> (ø)
src/tensor/variable.rs 97.50% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4287874...87fd5c6. Read the comment docs.

@c0dearm c0dearm self-assigned this Jun 27, 2022
@c0dearm c0dearm added the enhancement New feature or request label Jun 27, 2022
@c0dearm c0dearm added this to the v0.6.0 milestone Jun 27, 2022
@c0dearm c0dearm merged commit a9d4769 into main Jun 27, 2022
@c0dearm c0dearm deleted the conv2d branch August 27, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants