Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Alpine cotation missing on ice climbing outing #2570

Closed
flob38 opened this issue Mar 2, 2022 · 2 comments
Closed

Bug: Alpine cotation missing on ice climbing outing #2570

flob38 opened this issue Mar 2, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@flob38
Copy link
Contributor

flob38 commented Mar 2, 2022

Alpine cotation should be available when creating outing.
Ice cotation is the only one available.
chrome_screenshot_1646289738252

@flob38 flob38 added the bug Something isn't working label Mar 2, 2022
@brunobesson brunobesson changed the title Bug: Alpine cotation missing on outing Bug: Alpine cotation missing on ice climbing outing Mar 9, 2022
@brunobesson
Copy link
Member

OK, so the global_rating is not defined for ice climbing outings, indeed:

So I guess the fix should be made on both sides. I tried modifying the UI only, and the gloabl_rating, when set, is not taken into account.

@cbeauchesne @lbesson @asaunier do you confirm? could you help with modifying the API? (I guess there is a little bit more than adding the fields, e.g. unit tests)

@brunobesson
Copy link
Member

I mistakenly commited the branch on master, so little more pressure to fix this on the API side, otherwise, if we do not revert, users will be able to set the global rating on their outing, but it won't be taken into account :)

@brunobesson brunobesson added this to the v7.6.8 milestone Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants