Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatter.js: Disabling quote doesn't work #97

Closed
TimPietrusky opened this issue Apr 14, 2015 · 4 comments
Closed

formatter.js: Disabling quote doesn't work #97

TimPietrusky opened this issue Apr 14, 2015 · 4 comments

Comments

@TimPietrusky
Copy link

When I try to disable the quoting like this:

var csv = require('fast-csv');

var csvStream = csv.createWriteStream({
  quote : null
});

it's not working, because the null value of options.quote is ignored while setting QUOTE in formatter.js:

QUOTE = options.quote || '"',

When I use the following option

var csvStream = csv.createWriteStream({
  quoteColumns : false
});

the fields are escaped / quoted, too.

Example

What I want: my text;text with " in it;another text
What I get: my text;"text with "" in it";another text

@pasynkov
Copy link

+1

@dustinsmith1024
Copy link
Contributor

If you guys submit a PR we can get it reviewed and merged. I don't think anyone is actively working on this.

@aalexgabi
Copy link

+1

doug-martin added a commit that referenced this issue Jul 29, 2019
* Changed to allow the `quote` option to be provided as a boolean so when set to false all quoting is ignored.
doug-martin added a commit that referenced this issue Jul 30, 2019
@doug-martin
Copy link
Contributor

Fixed with v3.4.0 you can now set quote to false to disable all quoting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants