Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'data' is not defined #3

Closed
OlafHaalstra opened this issue Jan 3, 2022 · 1 comment · Fixed by #5
Closed

'data' is not defined #3

OlafHaalstra opened this issue Jan 3, 2022 · 1 comment · Fixed by #5
Labels
bug Something isn't working

Comments

@OlafHaalstra
Copy link
Contributor

The dictionary on the following line is not defined:

ADExplorerSnapshot.py/adexpsnapshot/__init__.py

Line 275 in 33708fa

data['AllowedToDelegate'].append(sid)

Pull requests coming your way.

Another issue is that the following attribute is not used, do you want to keep in in there for future use?

ADExplorerSnapshot.py/adexpsnapshot/__init__.py

Line 225 in 33708fa

samname = ADUtils.get_entry_property(entry, 'sAMAccountName')

@c3c c3c closed this as completed in 977607f Jan 3, 2022
@c3c
Copy link
Owner

c3c commented Jan 3, 2022

Thanks for reporting this issue!
Pushed 977607f which renames data to computer and removed the samname variable.

@OlafHaalstra OlafHaalstra mentioned this issue Jan 3, 2022
Merged
@c3c c3c added the bug Something isn't working label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated flags for snapshot and output folder support OlafHaalstra/ADExplorerSnapshot.py
2 participants
@c3c @OlafHaalstra