Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. #2130

Open
jamesuejio opened this issue Aug 7, 2017 · 2 comments

Comments

@jamesuejio
Copy link

jamesuejio commented Aug 7, 2017

Expected Behavior

c3.js should be optimized for performance

Current Behavior

Chrome throws warning
[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.

Possible Solution
Change
addEventListener(eventType, method); to
addEventListener(eventType, method. {passive: true});

Steps to Reproduce (for bugs)
Create a chart and check the console.

Environment
c3.js version: 0.4.13
Browser name and version: Chrome 59.0.3071.115

@FraTheVet
Copy link

FraTheVet commented Aug 31, 2017

Worth noticing that one needs to have their Chrome console set to output Verbose level to see [Violation] outputs, but yes it seems a good point of optimization.

@KevinMcGin
Copy link

Has there been any progress on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants