Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient Send is returning wrong response code #223

Closed
imtrobin opened this issue Oct 4, 2020 · 5 comments
Closed

HttpClient Send is returning wrong response code #223

imtrobin opened this issue Oct 4, 2020 · 5 comments

Comments

@imtrobin
Copy link

imtrobin commented Oct 4, 2020

I see your fork has the same bug

cocos2d/cocos2d-x#20593

@halx99 halx99 closed this as completed in 9586f95 Oct 4, 2020
@halx99
Copy link
Collaborator

halx99 commented Oct 4, 2020

thanks, fixed

@imtrobin
Copy link
Author

imtrobin commented Oct 5, 2020

actually, I noticed android http client is also returning wrong response code (-1), I have yet to fix it

@halx99
Copy link
Collaborator

halx99 commented Oct 5, 2020

Good, and engine-x unify HttpClient impl with curl on all platforms

@imtrobin
Copy link
Author

imtrobin commented Oct 5, 2020

I think they are discussing to use okhttp. Hmm, I can't seem to fix it in Android, the HTTPURKLConnection.java does not return the responsecode if connect fails

@imtrobin
Copy link
Author

imtrobin commented Oct 7, 2020

The Android version is working fine, was silly mistake on my part, so the fix for the curl is good .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants