refactor(flags): refactor boolean type

c4spar · Mar 22, 2020 · 10997f6 · 10997f6
1 parent 8228ac1
commit 10997f6
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/flags/lib/types/boolean.ts b/packages/flags/lib/types/boolean.ts
@@ -6,15 +6,17 @@ export const boolean: ITypeHandler<boolean> = ( option: IFlagOptions, arg: IFlag
         arg.optionalValue = true;
     }
 
-    if ( value && ~[ '1', 'true' ].indexOf( value ) ) {
+    if ( !value ) {
+        return;
+    }
+
+    if ( ~[ '1', 'true' ].indexOf( value ) ) {
         return true;
     }
 
-    if ( value && ~[ '0', 'false' ].indexOf( value ) ) {
+    if ( ~[ '0', 'false' ].indexOf( value ) ) {
         return false;
     }
 
-    if ( value ) {
-        throw new Error( `Option --${ option.name } must be of type boolean but got: ${ value }` );
-    }
+    throw new Error( `Option --${ option.name } must be of type boolean but got: ${ value }` );
 };