chore: fix nightly tests (#97)

* test(command): fix nightly test * test(command): fix nightly test * chore(ci): update lint test
c4spar · Oct 10, 2020 · e0093b7 · e0093b7
1 parent 32f01e0
commit e0093b7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -3,15 +3,20 @@ name: Lint
 on: [push, pull_request]
 
 jobs:
-  build:
+
+  lint:
     name: Lint source
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
     steps:
       - name: Setup repo
-        uses: actions/checkout@master
+        uses: actions/checkout@v2
 
       - name: Setup Deno
-        uses: denolib/setup-deno@master
+        uses: denolib/setup-deno@v2
+        with:
+          deno-version: v1.x
 
       - name: Setup shellcheck
         run: >

diff --git a/command/test/command/help_command_test.ts b/command/test/command/help_command_test.ts
@@ -3,6 +3,8 @@ import { CompletionsCommand } from "../../completions/mod.ts";
 import { HelpCommand } from "../../help/mod.ts";
 import { Command } from "../../command.ts";
 
+const isNightly: boolean = Deno.version.deno.match(/nightly/) !== null;
+
 function command(defaultOptions?: boolean, hintOption?: boolean) {
   const cmd = new Command()
     .throwErrors()
@@ -64,7 +66,7 @@ function command(defaultOptions?: boolean, hintOption?: boolean) {
 
 Deno.test({
   name: "command: help command with line break (deno <= v1.4.0)",
-  ignore: gt(Deno.version.deno, "1.4.0"),
+  ignore: isNightly || gt(Deno.version.deno, "1.4.0"),
   async fn() {
     const output: string = command(true, false).getHelp();
 
@@ -107,7 +109,7 @@ Deno.test({
 Deno.test({
   name:
     "command: help command with line break but without default options (deno <= v1.4.0)",
-  ignore: gt(Deno.version.deno, "1.4.0"),
+  ignore: isNightly || gt(Deno.version.deno, "1.4.0"),
   async fn() {
     const output: string = command(false, false).getHelp();
 
@@ -147,7 +149,7 @@ Deno.test({
 
 Deno.test({
   name: "command: help command with line break (deno >= v1.4.1)",
-  ignore: lt(Deno.version.deno, "1.4.1"),
+  ignore: !isNightly && lt(Deno.version.deno, "1.4.1"),
   async fn() {
     const output: string = command(true, true).getHelp();
 
@@ -192,7 +194,7 @@ Deno.test({
 Deno.test({
   name:
     "command: help command with line break but without default options (deno >= v1.4.1)",
-  ignore: lt(Deno.version.deno, "1.4.1"),
+  ignore: !isNightly && lt(Deno.version.deno, "1.4.1"),
   async fn() {
     const output: string = command(false, true).getHelp();