-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New commandline flag to not check/update the configured files #149
Conversation
55fd6dc
to
040f0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this makes sense, just some minor suggestions to improve its quality.
bumpversion/cli.py
Outdated
# do not use the files, from the config | ||
if args.no_configured_files: | ||
files = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be clearer to dot his right after calling _load_configuration
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not possible because args is at that point a list - it probably gets populated later with the commandline arguments
c5e5a6b
to
c6a5b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'd prefer if someone else also reviewed the work.
Perhaps we should also squash the commits?
Use-cases: * just retrieving the new version without modifying/checking the files * updating only a particular file with e.g., bump2version --no-configured-files major my-file.txt
2bf30b9
to
8f41535
Compare
@c4urself can you merge this PR too? this is the last feature to avoid having a custom-built bump2version in our pipelines Right now I need this for this: since changelog and versioning are two concerns in the code and changelog-bumping should only happen on minor-version increments, I need this flag |
I think sufficient time has passed for other reviewers and LGTM. |
thanks! |
Use-cases:
With the
-h
text I'm not sure: I'm open for suggestions :-)