Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should *examples* be React components or elements #108

Open
jxnblk opened this issue Apr 27, 2018 · 0 comments
Open

Should *examples* be React components or elements #108

jxnblk opened this issue Apr 27, 2018 · 0 comments

Comments

@jxnblk
Copy link
Member

jxnblk commented Apr 27, 2018

Currently the dev server filters JS files and only attempts to render components (e.g. functions, props => <Button>Hello</Button>). For snapshots, storybook stories, etc., a static React element is usually good enough (and we don't pass props into these anyhow) – e.g. <Button>Beep</Button>.

It's probably a good idea to either make the dev server handle elements as well, or perhaps make all the utilities handle both components and elements

@johno johno added the v1 label May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants