Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog #20

Open
dlussky opened this issue Oct 30, 2014 · 14 comments
Open

Changelog #20

dlussky opened this issue Oct 30, 2014 · 14 comments

Comments

@dlussky
Copy link
Contributor

dlussky commented Oct 30, 2014

Hi.
I just tried to update from 2.0.3 to 2.0.9 and noticed, that you removed a public method:

Call to undefined method GetOptionKit\OptionCollection::printOptions()

Could you please maintain a changelog for breaking changes like this?)
I see, that new behavior is reflected in example.php, and i like the new OptionPrinter, but it would be nice to have a brief changelog, at least a one line at release comment)

@dlussky dlussky changed the title Changelog! Changelog Oct 30, 2014
@dlussky
Copy link
Contributor Author

dlussky commented Oct 30, 2014

*And by the way, two mentions of the old method is still there)

public function printOptions( $class = 'GetOptionKit\OptionPrinter' )

https://github.com/c9s/GetOptionKit/blame/a4561a9571a2224cde80953fe5ac2a158a5310b6/README.md#L142

@dlussky
Copy link
Contributor Author

dlussky commented Oct 30, 2014

*And actually, i liked the concept of the new Printer, but not the default implementation) It consumes 3 times more screen space, than previous one, i'll make a PR, once i'll migrate to 2.0.9 and make compact printer)

@alakra
Copy link

alakra commented Dec 21, 2014

👍

@c9s
Copy link
Owner

c9s commented Dec 22, 2014

sorry i missed your mail. PRs for this are welcomed! Thanks!

@c9s
Copy link
Owner

c9s commented Dec 22, 2014

and yeah I will maintain a changelog for this

@c9s
Copy link
Owner

c9s commented Dec 22, 2014

public function printOptions( $class = 'GetOptionKit\OptionPrinter' )

This method will be deprecated.

@c9s
Copy link
Owner

c9s commented Dec 22, 2014

About the printer class, I think you can create a CompactPrinter class for printing information with compact format.

@dlussky
Copy link
Contributor Author

dlussky commented Dec 22, 2014

Ah, sure, i almost forgot about that issue, because i decided to stay at version 2.0.3 for now. But i'm sure I'll come back to this sometime soon)

@c9s
Copy link
Owner

c9s commented Dec 24, 2014

I am sorry this change breaks your application. The change was for the new CLIFramework, which is to achieve the completion support. I guess you might be interested in, you can take a look at here: https://github.com/c9s/CLIFramework#automatic-zsh-completion-generator

@dlussky
Copy link
Contributor Author

dlussky commented Dec 24, 2014

Wow! That's really nice, I'll give it a try on holidays)

@c9s
Copy link
Owner

c9s commented Apr 23, 2015

Changelog updated here: https://github.com/c9s/GetOptionKit/blob/master/CHANGELOG.md

@c9s
Copy link
Owner

c9s commented May 12, 2016

fyi: we just reached 95% test coverage on 2.3.x

@dlussky
Copy link
Contributor Author

dlussky commented May 12, 2016

Well, to my shame I didn't touch that matter since 2014, and i'm still using 2.0.3 in that project, since the cli part is strictly for internal use and it "just works") I'm thrilled to check out the new version sometime soon, though) Thank you very much for your work)

@c9s
Copy link
Owner

c9s commented May 12, 2016

@dlussky not a problem! just to inform you that we have something new coming in year. :)

Thank you for using them and keep them alive! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants