Add check for blank env key #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 98.31% 98.34% +0.02%
==========================================
Files 1 1
Lines 237 241 +4
==========================================
+ Hits 233 237 +4
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
caarlos0
reviewed
Feb 1, 2021
|
Thanks |
nexoscp
added a commit
to nexoscp/env
that referenced
this pull request
Apr 7, 2022
* Added blank key check Fixes rouge blank env keys in the environment having unexpected results caarlos0#152 * Added test for blank env key Test for rogue blank env key fix for caarlos0#152 * refactor: else Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check (and corresponding test) to prevent rogue blank env keys in the environment from producing unexpected results on fields without
envtags, as per #152 .