Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move global target merging responsibility to checks #100

Open
1 task done
lvlcn-t opened this issue Feb 7, 2024 · 0 comments
Open
1 task done

Refactor: Move global target merging responsibility to checks #100

lvlcn-t opened this issue Feb 7, 2024 · 0 comments
Labels
area/checks Issues/PRs related to Checks refactoring Refactoring of existing code

Comments

@lvlcn-t
Copy link
Member

lvlcn-t commented Feb 7, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Problem Description

The global targets are injected to the checks config into their target field. This was ok for the target manager MVP but the checks will become more complex and not every check can implement a string slice as target field.

Solution Description

Add a dedicated global targets field to the checks config structs. This field can then be merged into the targets field by the check itself depending on its config implementation.

Who can address the issue?

Everyone

Additional Context

No response

@lvlcn-t lvlcn-t added refactoring Refactoring of existing code area/checks Issues/PRs related to Checks labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/checks Issues/PRs related to Checks refactoring Refactoring of existing code
Projects
None yet
Development

No branches or pull requests

1 participant