Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

###Leaderboard: hit the API #2

Merged
merged 10 commits into from Jun 16, 2022
Merged

###Leaderboard: hit the API #2

merged 10 commits into from Jun 16, 2022

Conversation

developerwaleed
Copy link
Owner

Leaderboard: hit the API πŸ‘

  • Create a new game with the name of your choice by using the API. βœ…
  • Implement the "Refresh" button (receiving data from the API and parsing the JSON) βœ… .
  • Implement the form "Submit" button (sending data to the API). βœ…
  • Use async and await JavaScript features to consume the API.βœ…

Copy link

@ShadyShawkat ShadyShawkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Caasperr,

Good job so far! πŸ‘πŸ»
There are some issues that you still need to work on to go to the next project but you are almost there!

Image

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/index.js Show resolved Hide resolved
src/js/appFunctions.js Outdated Show resolved Hide resolved
src/js/getData.js Outdated Show resolved Hide resolved
Copy link

@tufoinnkuo10 tufoinnkuo10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved βœ”οΈ

Hi @Caasperr

Your project is complete! Great job for adding the required changesπŸ₯‡. There is nothing else to say other than... it's time to merge it 🍾🚒 :shipit: . Congratulations! πŸŽ‰πŸ’―πŸŒŸ

Good Points πŸ‘

  • Descriptive Pull Request
  • Validations correctly implemented
  • No linter errors
  • API endpoint gotten
  • App runs as expected

Cheers..Happy coding!..and keep soaring higher! πŸ’» 🍷 πŸš€

tufoin

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

@developerwaleed developerwaleed merged commit 9c29f27 into dev Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants