Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use npm published version of cabal-node and hyperdb #16

Closed
okdistribute opened this issue May 22, 2018 · 4 comments
Closed

use npm published version of cabal-node and hyperdb #16

okdistribute opened this issue May 22, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@okdistribute
Copy link
Member

okdistribute commented May 22, 2018

hyperdb and cabal-node are being referenced in package.json at their github versions, which will cause incompatibility with different installations of cabal depending on when the person installed cabal. It also means incompatibility with other clients (such as Desktop, which depends on particular npm versions).

Can we use npm published versions of these repositories? This also means that we will likely need to advance cabal-node through npm rapidly, but it is better software release practice overall and will improve reliability.

https://github.com/cabal-club/cabal/blob/master/package.json#L15

@okdistribute okdistribute added the bug Something isn't working label May 22, 2018
@cblgh
Copy link
Member

cblgh commented May 22, 2018

Yeah! I'm all for this! I was just being a hacky hackson when I did that initially, I'll follow your lead re versioning of cabal-node as I'm not that experienced with minting semver releases

@okdistribute
Copy link
Member Author

A good rule of thumb:

  • backwards compatibility change use npm version major
  • new feature npm version minor
  • bug npm version patch

then do git push --tags origin master
and then npm publish

@cblgh
Copy link
Member

cblgh commented May 24, 2018

alright! i just published cabal@2.0.0 and cabal-node@2.0.0

@okdistribute
Copy link
Member Author

nice!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants