Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal replication bug #51

Closed
rhodey opened this issue Jul 30, 2019 · 3 comments
Closed

cabal replication bug #51

rhodey opened this issue Jul 30, 2019 · 3 comments

Comments

@rhodey
Copy link

rhodey commented Jul 30, 2019

A null reference error gets thrown from deep inside multifeed after cabal replication has been started with cabal.swarm(). Please see my proof-of-concept with steps to reproduce for more details.

/root/poc/node_modules/multifeed/mux.js:203
      feed.ready(function() { // wait for each feed to be ready before replicating.
           ^

TypeError: Cannot read property 'ready' of undefined
    at /root/poc/node_modules/multifeed/mux.js:203:12
    at Array.forEach (<anonymous>)
    at startFeedReplication (/root/poc/node_modules/multifeed/mux.js:202:11)
    at /root/poc/node_modules/multifeed/index.js:238:7
    at release (/root/poc/node_modules/mutexify/index.js:23:13)
    at /root/poc/node_modules/multifeed/index.js:275:11
    at /root/poc/node_modules/multifeed/index.js:307:27
    at /root/poc/node_modules/hypercore/index.js:213:15
    at apply (/root/poc/node_modules/thunky/index.js:44:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
@hackergrrl
Copy link
Member

hackergrrl commented Jul 30, 2019

Thank you for reporting this @rhodey! 🌟

Looking into this revealed a bug in multifeed, which has been fixed. I've also bumped cabal-cli to 7.1.6, so upgrading that should pick up the patch. Thanks again!

@rhodey
Copy link
Author

rhodey commented Jul 30, 2019

@noffle glad to be helpful!

@telamon
Copy link
Contributor

telamon commented Jul 31, 2019

Ouch... Amazing sleuthing @noffle 👏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants