Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioBufferPlayer stop time doesn't work #212

Closed
kikohs opened this issue Mar 25, 2022 · 1 comment
Closed

AudioBufferPlayer stop time doesn't work #212

kikohs opened this issue Mar 25, 2022 · 1 comment
Labels
bug Something isn't working done

Comments

@kikohs
Copy link

kikohs commented Mar 25, 2022

I'm trying to stop a sample from playing after some time but it doesn't work.
Looking at the code, the stop(time), time parameter is unused.

@kikohs kikohs added the bug Something isn't working label Mar 25, 2022
@steam0r
Copy link
Collaborator

steam0r commented Mar 30, 2022

hey, that's a bug. thanks for reporting. then again i think this can be patches with a delay and the start/stop boolean. the implementation regarding start/stop-time in webaudio also is a bit confusing. so even if this would be working it might not be what you want

WebAudio/web-audio-api#2452

we are actually thining about removing these parameters, since it can be done "on the outside".

let me know if this helps and what you think

@steam0r steam0r added the done label Apr 1, 2022
@steam0r steam0r closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done
Projects
None yet
Development

No branches or pull requests

2 participants