Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid leaking generated code in public API #141

Open
nickmeinhold opened this issue Jun 24, 2024 · 0 comments
Open

Avoid leaking generated code in public API #141

nickmeinhold opened this issue Jun 24, 2024 · 0 comments

Comments

@nickmeinhold
Copy link

Am i right in assuming this is a goal of the library?

If so, some examples of where generated classes are exposed to the public API are:

  • FirestoreGateway.createDocument takes a fs.Document document rather than a Document.
  • FirestoreGateway.updateDocument exposes fs.Document document
  • FirestoreGateway.runQuery exposes StructuredQuery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickmeinhold