Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Scheduled statuses #404

Closed
wants to merge 3 commits into from
Closed

[WIP] Scheduled statuses #404

wants to merge 3 commits into from

Conversation

jbrooksuk
Copy link
Member

  • Update incident form.
  • Build in date picker.
  • Store scheduled statuses.
    • Fix bug where publish_at date doesn't get stored.
  • Language files.
  • Continue to show incidents but which don't have the same publish_at as they do created_at - optional?
  • Show scheduled statuses above incidents.

GrahamCampbell
GrahamCampbell reviewed Jan 18, 2015
View reviewed changes
bower.json
@@ -12,7 +12,8 @@
"Sortable": "~1.0.0",
"animate-sass": "~0.6.2",
"moment": "~2.8.4",
"livestampjs": "~1.1.2"
"livestampjs": "~1.1.2",
"bootstrap-datepicker": "1.3.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ~1.3.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember doing this after realising I'd forgotten - but I know why now. The tilde character in OSX is a modifier and if you don't provide a character to modify the ~ will disappear.

@jbrooksuk jbrooksuk added this to the First Release (v1.0.0) milestone Jan 21, 2015
@jbrooksuk
Copy link
Member Author

I'm wondering if we should actually split the scheduled statuses into a different page? The reason for this is that scheduled statuses wouldn't likely have a status - you'd use them for maintenance etc. The other way is when a published_at date is chosen, we could disable the statuses and just send through 0.

@jbrooksuk
Copy link
Member Author

CC @cachethq/owners

joecohens
joecohens reviewed Jan 23, 2015
View reviewed changes
src/Http/Controllers/HomeController.php
@@ -48,7 +48,7 @@ public function showIndex()

foreach (range(0, $incidentDays) as $i) {
$date = $startDate->copy()->subDays($i);
$incidents = Incident::whereBetween('created_at', [
$incidents = Incident::notScheduled()->whereBetween('created_at', [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disappear the status once the published date is today, we need a way to put it back to the normal flow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the published_at date on the where here.

@jbrooksuk jbrooksuk force-pushed the scheduled-statuses branch 2 times, most recently from 594b583 to ca158cf Compare January 25, 2015 11:05
@jbrooksuk
Copy link
Member Author

Also, we should offer scheduled incidents at a certain time.

@jbrooksuk jbrooksuk self-assigned this Jan 30, 2015
@jbrooksuk
Copy link
Member Author

Rebased.

@jbrooksuk
Copy link
Member Author

I'm going to move scheduled statuses into a new form, rather than dirtying the existing one.

@jbrooksuk jbrooksuk mentioned this pull request Feb 13, 2015
Closed
@jbrooksuk
Copy link
Member Author

@GrahamCampbell what's going on with your Markdown package?

@GrahamCampbell
Copy link
Contributor

I told you this already. You need to clear out your composer cache. It's using a version that doesn't even exist.

@jbrooksuk
Copy link
Member Author

I did.

@GrahamCampbell
Copy link
Contributor

Did you run these commands?

composer self-update
composer clear-cache
rm -rf vendor
rm composer.lock
composer install

NB, composer update doesn't cut it because composer is stupid.

@jbrooksuk
Copy link
Member Author

I rebased master on to this branch and pushed so hopefully Travis will pass now.

@jbrooksuk jbrooksuk force-pushed the scheduled-statuses branch 3 times, most recently from b8e97d1 to da1c78f Compare February 21, 2015 18:49
@jbrooksuk
Copy link
Member Author

Rebased.

@jbrooksuk
Copy link
Member Author

I've messed up a rebase here and lost a few things from master. Will need to redo this now 😠

@jbrooksuk jbrooksuk closed this Feb 28, 2015
@jbrooksuk jbrooksuk deleted the scheduled-statuses branch February 28, 2015 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbrooksuk jbrooksuk

Labels
None yet
Projects
None yet
Milestone
V1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbrooksuk @GrahamCampbell @joecohens