Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automating the Cachet installation #2924

Closed
nalysius opened this issue Feb 24, 2018 · 8 comments
Closed

Automating the Cachet installation #2924

nalysius opened this issue Feb 24, 2018 · 8 comments
Assignees
Labels
Enhancement Good First Issue If you're looking for a good issue to PR, start here Setup

Comments

@nalysius
Copy link
Contributor

nalysius commented Feb 24, 2018

Hi,

On Slack I discussed with someone that needed to automate the installation of Cachet, and because I'm interested by this feature I create this issue in order to contribute then.

The command app:install creates the tables in the database, but does not fill the settings nor the users table.
I would like to add an optional parameter (or create a subclass) to app:install in order to give as parameter the path to a file that contains the settings to write into the database. So, the installation would be fully automated.

For now even after executing app:install the database is empty, so it's mandatory to launch the setup page that asks for a user, mail drivers, app name and so on.
Also if I've already set the .env file with Cache driver, Mail driver and so on, is it required to ask for them on the setup page? Or at least pre-fill the select box could be a help.

I've looked in the app/Console/Command directory but all the commands inside are cachet:* and I don't know where the app:install command is located. Also, do you have guidelines about that? Like the usage of a json or any other file type to manage this configuration.

Regards,

Cachet 2.4
Commit number 2d8bf2f

@jbrooksuk
Copy link
Member

@anthonybocci app:install is setup by https://github.com/GrahamDeprecated/Laravel-Core

I did start a fully automated solution in #2290 with @joecohens extending it to create the user in #2291

@nalysius
Copy link
Contributor Author

nalysius commented Mar 6, 2018

Hi @jbrooksuk and thank you for your comment.

I've looked at the command cachet:install and if it does all the job it's absolutely great! But I have one question though, the line !$this->confirm('Do you want to install Cachet?') asks for the confirmation.
Is there a command line argument that we could supply line -y in order to fully automated installation?

@jbrooksuk
Copy link
Member

Yeah, that could be added to the command. Do you want to handle that yourself? We just need a flag which skips any confirmations with a default of yes.

@jbrooksuk
Copy link
Member

Alternatively, you could pipe into yes?

@nalysius
Copy link
Contributor Author

Indeed it could be piped to yes, you're right. So this is absolutely not a priority, but I think it would be nice if a flag could be given.
I'll have a look to that when I'll have time.

@jbrooksuk
Copy link
Member

👍

@jbrooksuk jbrooksuk added Enhancement Good First Issue If you're looking for a good issue to PR, start here up-for-grabs and removed Discussion labels Mar 16, 2018
@jbrooksuk
Copy link
Member

Updated the labels :)

@GrahamCampbell
Copy link
Contributor

Replaced by #3379.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Good First Issue If you're looking for a good issue to PR, start here Setup
Projects
None yet
Development

No branches or pull requests

3 participants