Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port or apply ODCA styles and branding #18

Closed
13 tasks done
adborden opened this issue Feb 18, 2018 · 3 comments
Closed
13 tasks done

Port or apply ODCA styles and branding #18

adborden opened this issue Feb 18, 2018 · 3 comments
Assignees
Labels
Projects

Comments

@adborden
Copy link
Member

adborden commented Feb 18, 2018

We want our jekyll site to look like the ODCA mocks and not necessarily the existing site. We should re-use the existing styles where possible but build towards the mocks if there is some divergence.

@adborden adborden created this issue from a note in MVP (Backlog) Feb 18, 2018
@adborden adborden moved this from Backlog to In progress in MVP Feb 18, 2018
@adborden adborden self-assigned this Feb 18, 2018
@adborden
Copy link
Member Author

After looking through the LESS files, I don't think we just want to convert it all. It's not organized well and there are a mix of CSS architecture styles so it's inconsistent. I'd rather not take on that tech debt and spend some time to weed it out. I'm working on the base styles now, if that ends up being difficult, we might just pull in all the converted files to speed up the work.

@adborden
Copy link
Member Author

I published this less-to-sass-conversion branch so folks can look at the converted LESS files. Not for merging ;)

@adborden
Copy link
Member Author

adborden commented Jun 2, 2018

Closing this out 🎉

@adborden adborden closed this as completed Jun 2, 2018
MVP automation moved this from In progress to Done Jun 2, 2018
@ghost ghost removed the in progress label Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
MVP
  
Done
Development

No branches or pull requests

1 participant