Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cacti 1.2.0] Ambiguous Toggle Switches in Sunrise Theme #2298

Closed
jplgps opened this issue Jan 10, 2019 · 5 comments
Closed

[Cacti 1.2.0] Ambiguous Toggle Switches in Sunrise Theme #2298

jplgps opened this issue Jan 10, 2019 · 5 comments
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@jplgps
Copy link

jplgps commented Jan 10, 2019

The parameter toggle switches that appear throughout Cacti do not indicate whether the parameter is enabled or disabled other than the switch being in the left or right position; its state is ambiguous. I suggest adding an element to clearly indicate whether the toggle is on/enabled - off/disabled.

screen shot 2019-01-10 at 10 41 43 am

@jplgps jplgps changed the title Cacti 1.2.0 - Ambiguous Toggle Switches in Sunrise Theme [ Cacti 1.2.0 ] Ambiguous Toggle Switches in Sunrise Theme Jan 10, 2019
@jplgps jplgps changed the title [ Cacti 1.2.0 ] Ambiguous Toggle Switches in Sunrise Theme [Cacti 1.2.0] Ambiguous Toggle Switches in Sunrise Theme Jan 10, 2019
@cigamit
Copy link
Member

cigamit commented Jan 11, 2019

Yea, I agree. We tried making it easier to discern in modern, dark, paw and paper-plane, but not sunrise.

@netniV
Copy link
Member

netniV commented Jan 11, 2019

Maybe in sunrise, we remove the trail that's to the right of the cacti (off), but leave the trail visible when it's to the left of the cacti (on).

@cigamit cigamit added the bug Undesired behaviour label Jan 11, 2019
@jplgps
Copy link
Author

jplgps commented Jan 11, 2019

Other suggestions:

What about an "LED" in the toggle switch that illuminates either red or green? Or, leave the cactus (make it a little bigger) and its color could toggle between red and green.
screen shot 2019-01-11 at 12 20 12 pm

cigamit added a commit that referenced this issue Jan 12, 2019
Ambiguous Toggle Switches in Sunrise Theme
cigamit added a commit that referenced this issue Jan 12, 2019
Ambiguous Toggles
@cigamit cigamit added the resolved A fixed issue label Jan 12, 2019
@cigamit
Copy link
Member

cigamit commented Jan 12, 2019

Tried staying to the theme. Should be more clear now.

@netniV
Copy link
Member

netniV commented Jan 15, 2019

I did another minor update and it should now look like this to keep it even more in the theme style:
image

@netniV netniV closed this as completed Jan 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants