-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Head/Tail filtering of log for more efficient searches #2548
Comments
Can you be more explainatory? As far as I am aware, that is exactly how it works. |
I think introducing the Head/Tail options would potentially speed up some searches but since the number of rows is linked to the filtered results of a search... it could get extremely confusing and lead to misunderstanding of what's being displayed in the results if we were to also add head/tail filtering. Some would expect the 500 to be maximum number of lines displayed after filtering, others the number trimmed before filtering even starts. If there was a way to automatically scroll from one log file to another, that would make life easier. |
So currently, having just been through this to add a feature to 1.3, the code loops through every line in the file to determine if it should display it and get an accurate line count. Once that is done, it then calculates the number of pages it would have from the displayed lines and then caclulates the start line and the end line. With all that info, it then reads the file for a second time and displays those appropriate lines that should be displayed. Currently, the code actually calculates whether to display a line twice so I have speeded that be up in 1.3 by caching the result. You may not notice that speed difference though as it would be tiny, especially given the following enhancement that may have an opposite effect: See #3679 and its associated commit for more info. |
Logs display Order vs head or tail
This is resolved now. |
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Suggest use "Head lines" for "Display Order => Oldest First'
And keep current 'Tail lines" for "Display Order => Newest First'
The text was updated successfully, but these errors were encountered: