Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If PHP location setting is invalid during install/upgrade, this should be notified on modules page #2748

Closed
cjwbath opened this issue Jun 21, 2019 · 2 comments
Assignees
Labels
bug Undesired behaviour CLI CLI related issue installer Installation issue
Milestone

Comments

@cjwbath
Copy link

cjwbath commented Jun 21, 2019

I saw an issue similar to #2665 where the installer showed none of the required PHP modules were installed for the CLI. They definitely were, according to php -m and manual execution of cli_check.php.

I was trying to install against a database imported from another server and it turns out the error was caused because the PHP binary was now in a different location to that specified by the path_php_binary value in the database's settings table. Because of the way utility_php_extensions() shells out then silences errors from json_decode, if there was an error running PHP we just get an empty string there. Once all the rest of the extension array processing is then done, it just looks to the GUI like none of the modules is installed for the CLI.

Once I did UPDATE SETTINGS set value = '/usr/bin/php' WHERE name = 'path_php_binary'; in the DB all was good. I suggest try to check the validity of that configuration setting (presence of the PHP CLI binary) earlier in the install process.

@netniV netniV added bug Undesired behaviour CLI CLI related issue installer Installation issue labels Jun 21, 2019
@netniV netniV added this to the v1.2.5 milestone Jun 21, 2019
@netniV netniV self-assigned this Jun 21, 2019
@cigamit
Copy link
Member

cigamit commented Jun 30, 2019

Any thoughts on this on @netniV?

@netniV
Copy link
Member

netniV commented Jul 1, 2019

Yes, I’m updating the code to check that the returned string is actually non-blank otherwise show a new message to report this possibility of an issue. It will require manually updating the path unless we can the order of the installation steps and that can’t happen till 1.3

@netniV netniV changed the title Installer erroneously shows no PHP CLI modules if PHP binary in unexpected location When the path_php_binary location is invalid, this should be notified during installation when checking modules Jul 1, 2019
@netniV netniV closed this as completed in 51a01bb Jul 1, 2019
@netniV netniV changed the title When the path_php_binary location is invalid, this should be notified during installation when checking modules If PHP location setting is invalid, this should be notified during installation when checking modules Jul 14, 2019
@netniV netniV changed the title If PHP location setting is invalid, this should be notified during installation when checking modules If PHP location setting is invalid during install/upgrade, this should be notified on modules page Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour CLI CLI related issue installer Installation issue
Projects
None yet
Development

No branches or pull requests

3 participants