Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using consolidation functions, retrieving the first step can cause errors #2925

Closed
skyjou opened this issue Sep 4, 2019 · 6 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@skyjou
Copy link
Contributor

skyjou commented Sep 4, 2019

Describe the bug
Cacti only output the MAX value on all graphs.

For example, the default "Interface Traffic" graph template will show the "MAX" value by "Line",
and show "AVERAGE" value by "Area". But My Cacti will draw them with same value.

To Reproduce
Steps to reproduce the behavior:

  1. All the graphs show the MAX value only, and the RRD commands is not correct:

Here is the graph template content:
Screenshot from 2019-09-04 15-29-50

It's RRD command output:
Screenshot from 2019-09-04 15-13-56

Expected behavior
Screenshot from 2019-09-04 14-52-17
(From another Cacti server)

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Browser: Chrome
  • Version: 76

Additional context
I have another Cacti 1.2.6 server, and it works well.

@netniV
Copy link
Member

netniV commented Sep 4, 2019

Can you copy/paste the text version of your outputs? They will be useful during diagnosis.

@cigamit
Copy link
Member

cigamit commented Sep 5, 2019

I can confirm this. Have to review the code to see what happened.

@cigamit
Copy link
Member

cigamit commented Sep 5, 2019

Okay, I recall this now. It was done due to an RRDtool quirk around the first RRA around the fact that the max and average would both be the same. Boy wish I had kept better notes on this. It did not show up sooner due to the coding error that was resolved recently that allowed it to go unchecked. Let me see if I can do better math. Maybe I'll just revert the change. More to follow.

@cigamit
Copy link
Member

cigamit commented Sep 5, 2019

The source commit was here. cd14f26#diff-e93c440af885a2ac30d2e08c774a3934 It had to do with Aggregate. I have to re-review the reason for the change.

cigamit added a commit that referenced this issue Sep 5, 2019
Problem with consolidation function after upgade to 1.2.6
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Sep 5, 2019
@cigamit
Copy link
Member

cigamit commented Sep 8, 2019

I'm going to close this now. Let me know if you are satisfied with the fix.

@cigamit cigamit closed this as completed Sep 8, 2019
@skyjou
Copy link
Contributor Author

skyjou commented Sep 9, 2019

I just test this fix on my two cacti servers. And both of them work perfectly. Thank you.

cigamit added a commit that referenced this issue Sep 11, 2019
Just some variable changes and an audit of the code just to ensure everything is correct.
@netniV netniV changed the title Problem with consolidation function after upgade to 1.2.6 When using consolidation functions, retrieving the first step can cause errors Sep 28, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants