Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors can occur upgrading from 0.8.x due to incorrectly detected data source profile id #3319

Closed
MrDibbley opened this issue Mar 4, 2020 · 8 comments
Assignees
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team installer Installation issue resolved A fixed issue
Milestone

Comments

@MrDibbley
Copy link

same as issue #1002

The database upgrade fails. Here are the failed statements (and internal db version). Everything goes ok till upgrade to db version 1.0.5

version 1.0.5
[Fail]
UPDATE data_template_data SET data_source_profile_id = WHERE data_source_profile_id = 0

Here, obviously, there is stg missing before the WHERE. All other errors (below) seem legit syntax.

image

set setmode as #1002 (comment) and retested same result?

Thanks

@netniV
Copy link
Member

netniV commented Mar 4, 2020

Do me a favour, run the following:

SELECT id FROM data_source_profiles ORDER BY `default` DESC LIMIT 1

@MrDibbley
Copy link
Author

SELECT id FROM data_source_profiles ORDER BY default DESC LIMIT 1;
Empty set (0.001 sec)

data_source_profiles never existed in the original 0.8 db

@netniV
Copy link
Member

netniV commented Mar 4, 2020

That should have been inserted by an earlier upgrade though (1.0.0 I would imagine).

@netniV netniV self-assigned this Mar 4, 2020
@netniV netniV added bug Undesired behaviour confirmed Bug is confirm by dev team installer Installation issue labels Mar 4, 2020
@netniV netniV added this to the 1.2.11 milestone Mar 4, 2020
@netniV
Copy link
Member

netniV commented Mar 4, 2020

OK, so looking at the v1.0.0 upgrade function, it attempts to look at data_template_data_rra if it exists. Does that exist on your 0.8.8h database?

@netniV
Copy link
Member

netniV commented Mar 4, 2020

If possible, I would like a dump of the 0.8.8 database emailed to developers@cacti.net so I can do a proper step through and see occurs.

@MrDibbley
Copy link
Author

yes data_template_data_rra exists in the 0.8 db, ill email you a mysqldump of the 0.8 db too.

@netniV
Copy link
Member

netniV commented Mar 4, 2020

Thanks, I'll take a look tonight.

@cigamit
Copy link
Member

cigamit commented Mar 8, 2020

This was resolved as of the merging of the fetch branch into the 1.2.x branch and will be resolved as a part of the 1.2.11 release. In the mean time, just download the 1.2.x branch ad restart the upgrade.

@cigamit cigamit added the resolved A fixed issue label Mar 8, 2020
@cigamit cigamit changed the title errors upgrading 0.8.8h to 1.2.9 Errors upgrading 0.8.x to latest Cacti due to incorrectly detected data source profile id Mar 8, 2020
cigamit added a commit that referenced this issue Mar 8, 2020
* Errors upgrading 0.8.x to latest Cacti due to incorrectly detected data source profile id
* This issue was detected and resovled in the fetch branch and merged into 1.2.x branch.
@cigamit cigamit closed this as completed Mar 8, 2020
@netniV netniV changed the title Errors upgrading 0.8.x to latest Cacti due to incorrectly detected data source profile id Errors upgrading from 0.8.x due to incorrectly detected data source profile id Apr 5, 2020
@netniV netniV changed the title Errors upgrading from 0.8.x due to incorrectly detected data source profile id Errors can occur upgrading from 0.8.x due to incorrectly detected data source profile id Apr 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team installer Installation issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants