Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When searching tree or list views, the URL does not update after changes #4045

Closed
GralfR opened this issue Jan 10, 2021 · 3 comments
Closed
Assignees
Labels
bug Undesired behaviour graphview Issue related to the Graphs page porting required Requires porting to develop resolved A fixed issue
Milestone

Comments

@GralfR
Copy link

GralfR commented Jan 10, 2021

Feature Request

be able to have a direct url link to a search-result/filter inside graph view/tree view.

Is your feature request related to a problem? Please describe

I updated from cacti 0.8.8 to 1.2.15. In 0.8.8 inside graph view using the filter/search on a device shown inside the tree-view I got all the graphs of the device shown, which the search-engine found. This is working on 1.2.15, too. But on 0.8.8 I saw the URL changing and including the search-string. So, inside my browser I was able to bookmark or copy that URL and e.g. send/show my search-result to a colleague and talk about it later.
In 1.2.15 this does not work anymore, because the filter/search-string seams to be stored inside the session, not inside the URL anymore.
After a lot of googling I read about a security-issue with the filter-parameter, which seams to be the reason, why this feature has been removed.

Describe the solution you'd like

Because we are using cacti on an internal network without connection to the internet, we do not have to worry a lot about security/hacking. If it is easy to just re-enable that URL-filter-parameter (maybe by user-settings including a warning) this would be okay for us.

Describe alternatives you've considered

If this is not possible, we need something like a "permanent link" to a filtered graph view, which should be able to guess by an external script. We would like to be able to get to a view of all the graphs of port 20 e.g. of a switch by just one URL link from a cacti-external site (inside the same network, not from outsite from the internet). But that URL should be that clear, that it only differs by the search-string from e.g. all graphs for port 24 of the same switch, because otherwise it would be hard to recode hundreds of links for hundreds of ports on a lot of switches, you know?

I've also searched the web for a plugin, which could do the job of creating a permanet link for my search-result, but didn't find a lot of plugins concerning links or filters. None of them would do the job, or did I miss something?

Additional context

Thanks

@GralfR GralfR added the enhancement General tag for an enhancement label Jan 10, 2021
@netniV
Copy link
Member

netniV commented Mar 17, 2021

I think your summary is correct. There is currently no way to get the search as part of the address bar url.

@TheWitness TheWitness added graphview Issue related to the Graphs page bug Undesired behaviour and removed enhancement General tag for an enhancement labels Apr 16, 2023
@TheWitness
Copy link
Member

It's really a regression. I've been noticing myself.

@TheWitness TheWitness added this to the v1.2.25 milestone Apr 16, 2023
@TheWitness TheWitness added the porting required Requires porting to develop label Apr 16, 2023
@TheWitness TheWitness changed the title Filter/Search-string by URL When searching tree or list views, the URL does not update after changes Jun 4, 2023
@TheWitness TheWitness self-assigned this Jun 4, 2023
TheWitness added a commit that referenced this issue Jun 4, 2023
When searching tree or list views, the URL does not update after changes
@TheWitness
Copy link
Member

This should be resolved now.

@TheWitness TheWitness added the resolved A fixed issue label Jun 4, 2023
TheWitness added a commit that referenced this issue Jun 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour graphview Issue related to the Graphs page porting required Requires porting to develop resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants