Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realtime Images are not always adhering to defined format #4074

Closed
browniebraun opened this issue Jan 21, 2021 · 2 comments
Closed

Realtime Images are not always adhering to defined format #4074

browniebraun opened this issue Jan 21, 2021 · 2 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.17

Comments

@browniebraun
Copy link
Member

browniebraun commented Jan 21, 2021 •
edited
Loading

Describe the bug

Realtime always returns PNG images and does not take the output format provided by the related graph templates into account.
When you are primarily using SVG, you will directly notice the washed-out, bad output.

image

image
@browniebraun browniebraun added the bug Undesired behaviour label Jan 21, 2021
@TheWitness TheWitness added the resolved A fixed issue label Jan 24, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Jan 24, 2021
@TheWitness
Copy link
Member

Went ahead and fixed it.

TheWitness added a commit that referenced this issue Jan 24, 2021
@TheWitness
Fixing Issue #4074
563fc2e 
Realtime ignores output format
@browniebraun browniebraun reopened this Jan 31, 2021
@browniebraun
Copy link
Member Author

Fix is not complete

browniebraun added a commit that referenced this issue Jan 31, 2021
@browniebraun
Complete #4074
44226b3 
- ensure that mime type will be updated.
- stop that rrd_function_process_graph_options will be forced to export PNG format only if Realtime has been identified as requestor.
TheWitness added a commit that referenced this issue Feb 23, 2021
@TheWitness
Double commit for #3796 and #4074
665a85a
@netniV netniV changed the title Realtime ignores output format Realtime Images are not always adhering to defined format Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
2 participants
@TheWitness @browniebraun