Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmenting roles can incorrectly link to roles instead of realms in rare cases #4190

Closed
TheWitness opened this issue Mar 22, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

The augmenting of roles in Cacti depends on a filename search in the plugin_realms table. However, the current search can lead to errors, specifically noted in the thold plugin where there is an administrative role for thold.php, but there is also a file graph_thold.php that also matches with the current search criteria. This does not break security in Cacti, but will prevent the thold.php role from moving into it's designated container.

Expected behavior

Realms should map correctly into their respective Roles.

@TheWitness TheWitness added the bug Undesired behaviour label Mar 22, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Mar 22, 2021
TheWitness added a commit that referenced this issue Mar 22, 2021
- Augmenting roles can incorrectly map realms to roles in select cases
@TheWitness TheWitness added the resolved A fixed issue label Mar 22, 2021
@netniV netniV changed the title Augmenting roles can incorrectly map realms to roles in select cases Augmenting roles can incorrectly map realms to roles in rare cases Apr 30, 2021
@netniV netniV changed the title Augmenting roles can incorrectly map realms to roles in rare cases Augmenting roles can incorrectly link to roles instead of realms in rare cases Apr 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant