Some display strings have invalid formatting that cannot be parsed

[jimidak]

Describe the bug

PHP string var substitution

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
   Management. --> Trees --> (could be any tree)

2. Click on '....'
   some tree, and then "Edit Tree"

3. See error
   "This tree has been locked for Editing on %1$s by %2$s."

Expected behavior

"This tree has been locked for Editing on 2023-07-13 19:13:53 by admin."

A clear and concise description of what you expected to happen.
THE PHP TEMPLATE/VARIABLE POPULATED WITH ACTUAL TIMESTAMP & USER

Screenshots

Desktop (please complete the following information)

• OS: [e.g. iOS]
  UBUNTU 20.04

• Browser [e.g. chrome, safari]
  BRAVE

• Version [e.g. 22]
  1.52.130

Additional context

tree.php - The 2 sprintf string variables (‘%1$s by %2$s’) are not getting substituted by the first and second parameters 'locked_date' & '(get_username($tree['modified_by’])'. Nothing in cacti logs or mysql (mariadb) logs.



versions:

OS Ubuntu 20.04.5 (5.4.0-137 kernel)
RRDtool 1.7.2-3 build2
NET-SNMP 5.8
PHP 7.4.3
MariaDB 10.5.18
Apache 2.4.41
Spine 1.2.23
Cacti 1.2.24

Add any other context about the problem here.

[TheWitness]

Thanks @jimidak. The debian dpk builds are a little different than source builds due to some issues with deprecated libraries. Thank for reporting though.

[jimidak]

Thank you @TheWitness. Appreciate the feedback. This was probably better posted on the phpBB Cacti Forum, but if there's any help here I can get, it would be appreciated.

[TheWitness]

@jimidak, grab the global_languages.php from the 1.2.x branch and see if that fixes it. I distinctly remember this being reported before.

[TheWitness]

@jimidak, grab the global_languages.php from the 1.2.x branch and see if that fixes it. I distinctly remember this being reported before.

[netniV]

It was reported and fixed before.

[jimidak]

@netniV , Sorry Mark, I searched issues, opened and closed, and couldn't find anything. Can you pls point me to it?

[jimidak]

@TheWitness , replacing global_languages.php from the 1.2.x branch didn't seem to have any efffect.

[netniV]

I'm pretty sure it was done as part of #5147 but there were a few other commits that addressed things too.

[netniV]

That said, @TheWitness did update login form in 3088272 for issue #5152 which seems to be this same issue so maybe that's why it sounds familar to us both. If so, it's still outstanding and we may need to double check for these usages?

[jimidak]

@netniV Thanks for the follow-up. And that 5152 issue sure looks liek the same type of ordered placeholder issue

[TheWitness]

It'll be raining here in SE Michigan tomorrow. Will spend some time digging through it if you don't beat it tom me @netniV.

[TheWitness]

Grab a fresh copy of tree.php from the 1.2.x branch. I found this syntax in a few more locations as well and have resolved the same issue there.

[jimidak]

@TheWitness , I downloaded the updated tree.php, rebooted the cacti server, logged back into the cacti UI, and tried again... and now it's working!! Thank you @TheWitness and @netniV, for your time and effort. Very appreciated.

When I unlock a tree for editing, now I get the time and username. ex.
This tree has been locked for Editing on 2023-07-17 10:32:00 by Jane Doe

[TheWitness]

Sure. Thanks for confirming. Note that in PHP WebApps reboot and the like is never required when using Apache.