Improve PHP 8.1 support when adding devices

[asd0109]

add new device very very slow

After adding, it was found device status is unknown.

logpage show error message.

i test cacti in ubuntu 20.04.6 php7.4 is ok no this error .

[TheWitness]

Good catch. What happens if you edit lib/snmp.php and add the following after global $banned_snmp_strings;?

    global $banned_snmp_strings;

    if ($string === null) {
        return '';
    }

[TheWitness]

PHP8 deprecations drive me nuts.

[asd0109]

i try , but fail :(

Good catch. What happens if you edit lib/snmp.php and add the following after global $banned_snmp_strings;?

    global $banned_snmp_strings;

    if ($string === null) {
        return '';
    }

i try it ,but failed .

[asd0109]

2023-09-08 13:13:43 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())

2023-09-08 13:13:43 - ERROR PHP ERROR: Uncaught TypeError: dechex(): Argument #1 ($num) must be of type int, string given in /var/www/html/cacti/lib/data_query.php:1378 Stack trace: #0 /var/www/html/cacti/lib/data_query.php(1378): dechex() #1 /var/www/html/cacti/lib/data_query.php(106): query_snmp_host() #2 /var/www/html/cacti/lib/api_device.php(1289): run_data_query() #3 /var/www/html/cacti/lib/api_device.php(1131): api_device_update_host_template() #4 /var/www/html/cacti/host.php(286): api_device_save() #5 /var/www/html/cacti/host.php(62): form_save() #6 {main} thrown in file: /var/www/html/cacti/lib/data_query.php on line: 1378
2023-09-08 13:13:43 - CMDPHP PHP ERROR Backtrace: (/host.php[62]:form_save(), /host.php[286]:api_device_save(), /lib/api_device.php[1131]:api_device_update_host_template(), /lib/api_device.php[1289]:run_data_query(), /lib/data_query.php[106]:query_snmp_host(), /lib/data_query.php[1231]:cacti_snmp_session_walk(), /lib/snmp.php[499]:format_snmp_string(), /lib/snmp.php[745]:trim(), CactiErrorHandler())
2023-09-08 13:13:43 - ERROR PHP DEPRECATED: trim(): Passing null to parameter #1 ($string) of type string is deprecated in file: /var/www/html/cacti/lib/snmp.php on line: 745

[TheWitness]

I forgot to tell you what line to put that code block on. That's why is didn't work.

[TheWitness]

Go to line 745, go up till you find the global again and paste there instead. You need to remove the first one you did too.

[asd0109]

Go to line 745, go up till you find the global again and paste there instead. You need to remove the first one you did too.

thank you ! i will feedback after i test it .

[TheWitness]

Download the lib/snmp.php from the 1.2.x branch. Should be fixed.

[asd0109]

2023-09-11 08:05:51 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())

2023-09-11 08:05:51 - ERROR PHP ERROR: Uncaught TypeError: dechex(): Argument #1 ($num) must be of type int, string given in /var/www/html/cacti/lib/data_query.php:1378 Stack trace: #0 /var/www/html/cacti/lib/data_query.php(1378): dechex() #1 /var/www/html/cacti/lib/data_query.php(106): query_snmp_host() #2 /var/www/html/cacti/lib/api_device.php(1289): run_data_query() #3 /var/www/html/cacti/lib/api_device.php(1131): api_device_update_host_template() #4 /var/www/html/cacti/host.php(286): api_device_save() #5 /var/www/html/cacti/host.php(62): form_save() #6 {main} thrown in file: /var/www/html/cacti/lib/data_query.php on line: 1378

I have tested it and cannot solve the problem.

add device page very very slow .