Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve option is not properly honoured when removing devices at command line #5489

Closed
nomisunrider opened this issue Sep 15, 2023 · 6 comments
Closed

Preserve option is not properly honoured when removing devices at command line #5489

nomisunrider opened this issue Sep 15, 2023 · 6 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue

Comments

@nomisunrider
Copy link

As the subject says, the "preserve" option is not accounted for in the logic of cli\remove_graphs.php startng at line 108.
This results in "ERROR: Invalid Argument: (preserve)" and datasources are deleted.
@nomisunrider nomisunrider added bug Undesired behaviour unverified Some days we don't have a clue labels Sep 15, 2023
@TheWitness
Copy link
Member

What Cacti release is this?

@nomisunrider
Copy link
Author

Not sure it matters, but I'm using 1.2.24.

I checked the branches and don't see any logic to handle the "preserve" option
Here is 1.2.x:
https://raw.githubusercontent.com/Cacti/cacti/1.2.x/cli/remove_graphs.php

@TheWitness
Copy link
Member

Yea, got it now. Not enough coffee this morning.

TheWitness added a commit that referenced this issue Sep 22, 2023
@TheWitness
Fixing #5489 --preserve option not handled
865db06 
remove_graphs.php does not handle "--preserve" option
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Sep 22, 2023
@TheWitness
Copy link
Member

Check out the latest updates.

@nomisunrider
Copy link
Author

That looks correct, thanks

@TheWitness
Copy link
Member

Cool. Thanks for the help.

TheWitness added a commit that referenced this issue Sep 23, 2023
@TheWitness
Fixing #5489 --preserve option not handled
99f136d 
remove_graphs.php does not handle "--preserve" option
@netniV netniV changed the title remove_graphs.php does not handle "--preserve" option Preserve option is not properly honoured when removing devices at command line Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheWitness @nomisunrider