Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings table updates for large values reverted by database repair #5561

Closed
unka65 opened this issue Oct 30, 2023 · 2 comments
Closed

Settings table updates for large values reverted by database repair #5561

unka65 opened this issue Oct 30, 2023 · 2 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@unka65
Copy link

unka65 commented Oct 30, 2023

I noticed the following in thold database.php function thold_setup_database() that it changes the base application table settings, column "value" size to 4096.

/* increase the size of the settings table */
db_execute("ALTER TABLE settings
	MODIFY COLUMN `value`
	varchar(4096) NOT NULL default ''");

I wonder if that is for values thold_down_text and thold_up_text.

In running the base application database repair for troubleshooting other, one repair was the settings table column value size from 4096 to 2048.

Checking Table: 'settings'
ERROR Col: 'value', Attribute 'Type' invalid. Should be: 'varchar(2048)', Is: 'varchar(4096)'

I thought I would to mention it in case it could be a potential data loss that should be noted somewhere if not already.

@TheWitness
Copy link
Member

I'll be darn. Let me transfer to cacti.

@TheWitness TheWitness transferred this issue from Cacti/plugin_thold Nov 11, 2023
@TheWitness TheWitness changed the title Settings table custum size reverted by database repair Settings table custmm size reverted by database repair Nov 16, 2023
@TheWitness TheWitness changed the title Settings table custmm size reverted by database repair Settings table custom size reverted by database repair Nov 16, 2023
TheWitness added a commit that referenced this issue Nov 16, 2023
Settings table custom size reverted by database repair
TheWitness added a commit that referenced this issue Nov 16, 2023
Settings table custom size reverted by database repair
@TheWitness TheWitness added bug Undesired behaviour resolved A fixed issue labels Nov 16, 2023
@TheWitness TheWitness added this to the 1.2.26 milestone Nov 16, 2023
@TheWitness
Copy link
Member

This will be resolved in the 1.2.26 release.

@netniV netniV changed the title Settings table custom size reverted by database repair Settings table updates for large values reverted by database repair Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants