Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV Exports may not always output data correctly #5586

Merged
merged 1 commit into from Nov 19, 2023
Merged

CSV Exports may not always output data correctly #5586

merged 1 commit into from Nov 19, 2023

Conversation

xmacan
Copy link
Member

@xmacan xmacan commented Nov 19, 2023

Please revise it. Export before fix:
csv_before

Export after my fix:
csv_after

@xmacan
Copy link
Member Author

xmacan commented Nov 19, 2023

Manuals rrdxport says:
The first sample will be the first sample starting immediately after --start. The last sample will be the one ending at or immediately after --end.

so $start_time -1

@TheWitness TheWitness merged commit 674d75e into Cacti:1.2.x Nov 19, 2023
6 checks passed
TheWitness pushed a commit that referenced this pull request Nov 19, 2023
@xmacan @TheWitness
fix CSV export - missing first row and wrong start time (#5586)
2dcd58b
@netniV netniV changed the title fix CSV export - missing first row and wrong start time CSV Exports may not always output data correctly Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xmacan @TheWitness