Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding a device, using the bulk walk option can make version information appear #5602

Closed
psycholand opened this issue Nov 29, 2023 · 3 comments
Closed

When adding a device, using the bulk walk option can make version information appear #5602

psycholand opened this issue Nov 29, 2023 · 3 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.26

Comments

@psycholand
Copy link

The case statement for "--bulk_walk" in cli/add_device.php is missing a "break".
@psycholand psycholand added bug Undesired behaviour unverified Some days we don't have a clue labels Nov 29, 2023
@TheWitness
Copy link
Member

What cacti version?

@psycholand
Copy link
Author

It was missing when the code for issue #4105 was committed (commit: afcb13b) on March 21, 2021. So from version 1.2.17 up to the current 1.2.25.

TheWitness added a commit that referenced this issue Dec 2, 2023
@TheWitness
Fixing #5602 - Bulk Walk Break Missing
feedfe6 
Missing "break" for case statement in cli/add_device.php
TheWitness added a commit that referenced this issue Dec 2, 2023
@TheWitness
Fixing #5602 - Bulk Walk Break Missing
768dbd8 
Missing "break" for case statement in cli/add_device.php
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Dec 2, 2023
@TheWitness TheWitness added this to the 1.2.26 milestone Dec 2, 2023
@TheWitness
Copy link
Member

Okay, this is fixed now. Thanks for reporting.

@netniV netniV changed the title Missing "break" for case statement in cli/add_device.php When adding a device, using the bulk walk option can make version information appear Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.26
Development

No branches or pull requests
2 participants
@TheWitness @psycholand