Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The search filter does not support Cyrillic on: #861

Closed
pautiina opened this issue Jul 17, 2017 · 4 comments
Closed

The search filter does not support Cyrillic on: #861

pautiina opened this issue Jul 17, 2017 · 4 comments
Labels
bug Undesired behaviour

Comments

@pautiina
Copy link
Contributor

pautiina commented Jul 17, 2017 •
edited

  • /cacti/host.php

  • /cacti/sites.php

  • /cacti/tree.php

  • /cacti/aggregate_graphs.php

  • /cacti/pollers.php
    And in other places.
    60

In the plugins search in Cyrillic works and works on:

  • /cacti/graphs.php

  • /cacti/data_sources.php
cigamit added a commit that referenced this issue Jul 20, 2017
@cigamit
Resolving Issue #861
0673e3c 
- The search filter does not support Cyrillic
- Also adding more __esc() to title and value attributes
- Also adding more missing i18n via audit
@cigamit
Copy link
Member

cigamit commented Jul 20, 2017

Should be resolved now. Issue was larger than expected, but there are other things being resolved at the same time. Please report findings.

@pautiina
Copy link
Contributor Author

Hello.
I see a lot of work is done :)
Almost everything works.
The filter does not work only on /cacti/automation_snmp.php page, it does not work at all. After clicking on button search, the line is reset and becomes empty.

@cigamit
Copy link
Member

cigamit commented Jul 20, 2017

Okay, I'll check that out, I'm going to revert a small piece in every file. Let me know if the result is any different.

cigamit added a commit that referenced this issue Jul 20, 2017
@cigamit
More changes for issue #861
30bbf22 
Filters not working properly for i18n
@cigamit cigamit added the bug Undesired behaviour label Jul 21, 2017
@pautiina
Copy link
Contributor Author

Hello.
I have full retest search filter and seaech on Cyrillic. I dont find any problems and now all works fine.
You did a great job of code and now everything is fine. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cigamit @pautiina