Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect SNMP responses can cause spine to crash #271

Closed
TheWitness opened this issue Jun 15, 2022 · 0 comments
Closed

Incorrect SNMP responses can cause spine to crash #271

TheWitness opened this issue Jun 15, 2022 · 0 comments
Labels
bug resolved
Milestone
v1.2.22

Comments

@TheWitness
Copy link
Member

Describe the bug

Spine crashes in some cases where the snmp agent returns incomplete data.

0x00005555555613e7 in snmp_get_base (current_host=current_host@entry=0x7fffd40048f0, snmp_oid=snmp_oid@entry=0x7fffd400a240 ".1.3.6.1.2.1.1.3.0", should_fail=should_fail@entry=true) at snmp.c:442

This is due to the response->variables being NULL. This causes a segmentation fault attempting to copy a null string.

Expected behavior

More reliable spine
@TheWitness TheWitness added the bug label Jun 15, 2022
@TheWitness TheWitness added this to the v1.2.22 milestone Jun 15, 2022
@TheWitness TheWitness changed the title spine encounters a segmentation fault due to incorrect snmp response Spine encounters a segmentation fault due to incorrect snmp response Jun 15, 2022
TheWitness added a commit that referenced this issue Jun 15, 2022
@TheWitness
Fixing Issue #271 - segmentation fault in snmp functions
1f520b7 
Spine encounters a segmentation fault due to incorrect snmp response
TheWitness added a commit that referenced this issue Jun 21, 2022
@TheWitness
More attempts to resolve #271
732033a
@netniV netniV changed the title Spine encounters a segmentation fault due to incorrect snmp response Incorrect SNMP responses can cause spine to crash Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolved
Projects
None yet
Milestone
v1.2.22
Development

No branches or pull requests
1 participant
@TheWitness