-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable /debug/vars endpoint #65
Comments
It looks like the prometheus library is importing the go stdlib expvar, which in turn is auto-registering Thank you for catching this! |
@dee-see I just released a fixed version. Let me know if it doesn't resolve the issue. |
Thank you very much for the very quick fix!! |
@dropwhile would you be open to some sort of |
@dee-see I have no problem adding something like that. 👍 EDIT: Maybe something like |
Specifications
There's a
/debug/vars
which dumps a bunch of information about the running process. It would be great if we could disable this with a command-line option. I had a quick look to open a PR but it wasn't obvious to me how this is done. If you have any pointers I'm happy to open the PR myself.Expected Behavior
A new command-line option to disable
/debug/vars
. I think it should be disabled by default but I understand it would be a breaking change.Actual Behavior
/debug/vars
cannot be disabledSteps to reproduce
Start camo and visit
/debug/vars
The text was updated successfully, but these errors were encountered: