Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last cmd in buffered should not end with \n #17

Closed
rtoma opened this issue Oct 5, 2015 · 3 comments
Closed

Last cmd in buffered should not end with \n #17

rtoma opened this issue Oct 5, 2015 · 3 comments
Labels
todo

Comments

@rtoma
Copy link

rtoma commented Oct 5, 2015

When using the buffered method each cmd added to the buffer ends with a newline character.

This caused the etsy statsd server and log zillions msgs like:

5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""
5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""
5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""
5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""
5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""
5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""
5 Oct 15:51:11 - DEBUG: Bad line: 1 in msg ""

Could you strip the last newline when flushing the buffer?
@dropwhile dropwhile added the todo label Oct 5, 2015
@dropwhile
Copy link
Member

Thanks for reporting!
Fix pushed. Can you check if that resolves the problem?

@rtoma
Copy link
Author

rtoma commented Oct 5, 2015

Fixed, like:
image

Thanks!

@dropwhile
Copy link
Member

:D

@rtoma rtoma mentioned this issue Oct 14, 2015
Open
@joeycumines joeycumines mentioned this issue Aug 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dropwhile @rtoma