Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build --with github.com/caddy-dns/cloudflare still only builds with v2.7.6 #76

Closed
wazerstar opened this issue May 3, 2024 · 6 comments

Comments

@wazerstar
Copy link

Will this be fixed in the near future ?

I made this ticket some time ago and its closed because it fixed fatal error in building but its still locked to only build up to caddy v2.7.6

Using

xcaddy build master --with github.com/caddy-dns/cloudflare@master=github.com/mohammed90/cloudflare@master

Allows building latest caddy, but that was just a bandaid at that time, what is the future looking like for this plugin.

@mholt
Copy link
Contributor

mholt commented May 3, 2024

I believe it won't be an issue once 2.8 is released, if I understand it correctly.

@wazerstar
Copy link
Author

wazerstar commented May 3, 2024

I believe it won't be an issue once 2.8 is released, if I understand it correctly.

So that would also work with all nightlies/beta's and not only for 2.8 final release?

@mholt
Copy link
Contributor

mholt commented May 3, 2024

What would also work?

@wazerstar
Copy link
Author

What would also work?

I mean you believe it will work for when 2.8 is released, but what with all small/beta/nightly releases after 2.8,

would xcaddy build master --with github.com/caddy-dns/cloudflare work with all small changes after that or would it only be after each milestone as caddy final releases?

@mholt
Copy link
Contributor

mholt commented May 3, 2024

My understanding is that the current issues are caused because Go doesn't see that 2.7.6 is a "child" of 2.7, because it was tagged from a separate branch other than master. But 2.8 will be tagged from master again, so I think everything should just work as expected then.

@mholt
Copy link
Contributor

mholt commented Jun 10, 2024

Should be fixed now with the release of 2.8

@mholt mholt closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants