-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fatal errors are not logged #36
Comments
What is the full error message? It should have a stack trace. Code somewhere is panicking -- it definitely should not be -- and the std lib is catching it. Because the Go standard library is catching it and emitting the log, the log is treated as DEBUG level, as std lib logs are usually noise in the context of Caddy. |
Maybe it would be a good idea to pattern match stack backtraces and emit some error log entry to indicate that something is gone horribly awry? Here's the backtrace as it appears in the log:
|
how did you compile cdp-cache? Which version of go? What command? What is your caddy file. ? |
Please ignore (I've deleted the comment I had made), I got mixed up and thought the backtraces were the same. The crash with cdp-cache was due to using caddy 2.5.1. |
Caddy version, built today using website "download" by adding just the caddyserver/cache-handler module:
Caddy config file for repro:
Command to repro:
Running caddy with error output:
|
Can you retry with the latest release please? |
I'm trying to use the cache handler and it wasn't working. The symptom:
Only after I turned on debug logging I got:
The text was updated successfully, but these errors were encountered: