Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding the SNI tests.
Ideally with an SNI less connection we don't to know the destination IP address, things in the cloud are load balanced, DNS changes.
This change supports this port only matching configuration
The configuration I would like to support is
Which would respond to
curl https://127.0.0.1/version
. In this case the CP matches perfectly but the host matcher does not.I guess an alternative could be, with a wildcard IP matcher.