Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for wildcards/ expression matching in header_up/ header_down #3913

Closed
gucki opened this issue Dec 12, 2020 · 4 comments
Closed

Add support for wildcards/ expression matching in header_up/ header_down #3913

gucki opened this issue Dec 12, 2020 · 4 comments
Labels
feature ⚙️ New feature or request
Milestone
v2.5.2

Comments

@gucki
Copy link
Contributor

gucki commented Dec 12, 2020

It seems Caddy does not support wildcards/ expression matching in the reverse proxy's header_up.

For example this does not remove any headers:

header_up -X-SHIBBOLETH-*

This works as expected, but is limited in its use:

header_up -X-SHIBBOLETH-LOGIN

It'd be great if Caddy would support wildcards/ expression matching in the reverse proxy's header_up/ header_down.
@gucki gucki changed the title Support wildcards/ expression matching in header_up Add support for wildcards/ expression matching in header_up/ header_down Dec 12, 2020
@mholt mholt added the feature ⚙️ New feature or request label Dec 12, 2020
@mholt mholt added this to the 2.x milestone Dec 12, 2020
@mholt mholt added the good first issue 🐤 Good for newcomers label Dec 12, 2020
@rajat315315 rajat315315 mentioned this issue Jan 25, 2021
Closed
@simaotwx
Copy link
Contributor

See #3992 (comment) for my suggestion

@mohitpm
Copy link

mohitpm commented Jul 23, 2021

@mholt I would like to work on some good first issue. can i take this up?

@francislavoie
Copy link
Member

Sure @Mohit-Pawar, just be aware of the prior work in #3992

@caddyserver caddyserver deleted a comment from Jonathanmarsh4 Dec 12, 2021
@caddyserver caddyserver deleted a comment Dec 26, 2021
@caddyserver caddyserver deleted a comment Jan 1, 2022
@caddyserver caddyserver deleted a comment Jan 16, 2022
@caddyserver caddyserver deleted a comment from ALEKSHA2282 Jan 22, 2022
@caddyserver caddyserver deleted a comment Feb 6, 2022
@caddyserver caddyserver deleted a comment Feb 6, 2022
@caddyserver caddyserver deleted a comment Apr 20, 2022
@caddyserver caddyserver deleted a comment Apr 20, 2022
@mholt mholt mentioned this issue Jun 8, 2022
Closed
@caddyserver caddyserver deleted a comment from Zagorrrr Jun 20, 2022
@francislavoie
Copy link
Member

This is completed by #4831

@francislavoie francislavoie modified the milestones: 2.x, v2.5.2 Jul 8, 2022
@francislavoie francislavoie removed the good first issue 🐤 Good for newcomers label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.5.2
Development

Successfully merging a pull request may close this issue.

Added regex pattern matching for Deleting Headers rajat315315/caddy
6 participants
@gucki @mholt @francislavoie @mohitpm @simaotwx and others