caddyhttp: Refactor and export SanitizedPathJoin for use in fastcgi #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I'll play with it a bit this evening 👍 |
francislavoie
approved these changes
Jun 14, 2021
|
Haven't heard back from the original reporter so I'm going to have to assume this is a satisfactory patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help prevent directory traversal within PHP apps. Basically we pulled
sanitizedPathJoin()out of the file server and put it intocaddyhttpand exported it so any middleware can use it for safe path joins.Still needs some testing on Windows CI and in actual PHP environments.